Skip to content

On Ubuntu, GetTimezone should return the long time zone name. #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2023
Merged

On Ubuntu, GetTimezone should return the long time zone name. #1380

merged 3 commits into from
Jul 6, 2023

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

This file is usually located in /etc/timezone and contains something like "America/Los Angeles" rather than "PDT" or "GMT", which is less preferred.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Unit test on Linux shows the new time zone name returned.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jul 6, 2023
@jonsimantov jonsimantov requested a review from a-maurice July 6, 2023 00:20
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 76a58c3
Last updated: Wed Jul 5 21:04 PDT 2023
View integration test log & download artifacts

Failures Configs
storage [TEST] [FAILURE] [Linux] [x64] [openssl]
(1 failed tests)  FirebaseStorageTest.TestDeleteWithMaxRetryDuration

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov enabled auto-merge (squash) July 6, 2023 00:26
@jonsimantov jonsimantov merged commit 76a58c3 into main Jul 6, 2023
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 6, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 6, 2023
tom-andersen pushed a commit that referenced this pull request Jul 17, 2023
@jonsimantov @tom-andersen
On Ubuntu, GetTimezone should return the long time zone name. (#1380)
82c0c78 
* On Ubuntu, GetTimezone should return the long time zone name.

* Fix buffer size.

* Format code.
@firebase firebase locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees

@a-maurice a-maurice

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonsimantov @a-maurice